Page MenuHomePhabricator
Differential D13272

Add a bunch of tests for subclass implementations
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 8:38 AM.
Tags
None
Referenced Files
F14489276: D13272.id.diff
Wed, Jan 1, 9:34 PM
Unknown Object (File)
Thu, Dec 26, 9:39 AM
Unknown Object (File)
Tue, Dec 17, 9:07 AM
Unknown Object (File)
Sun, Dec 15, 4:29 PM
Unknown Object (File)
Thu, Dec 12, 4:54 PM
Unknown Object (File)
Tue, Dec 10, 6:06 PM
Unknown Object (File)
Tue, Dec 10, 10:43 AM
Unknown Object (File)
Nov 19 2024, 1:53 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
eadler
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP1239cfdeaf3a: Add a bunch of tests for subclass implementations
Summary

Add a bunch of tests to ensure that subclasses behave.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6723
Build 6745: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32071.Jun 13 2015, 8:38 AM
joshuaspence retitled this revision from to Add a bunch of tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 8:38 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence mentioned this in D13273: Add some tests for subclasses.Jun 13 2015, 8:43 AM
joshuaspence mentioned this in D13274: Add some tests for subclasses.Jun 13 2015, 8:46 AM
epriestley accepted this revision.Jun 13 2015, 3:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2015, 3:24 PM
eadler accepted this revision.Jun 13 2015, 10:25 PM
eadler added a reviewer: eadler.
joshuaspence retitled this revision from Add a bunch of tests to Add a bunch of tests for subclass implementations.Jun 15 2015, 8:06 AM
joshuaspence edited edge metadata.
joshuaspence mentioned this in rPHU0cff5de51378: Add some tests for subclasses.Jun 15 2015, 8:06 AM
Closed by commit rP1239cfdeaf3a: Add a bunch of tests for subclass implementations (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 8:14 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in rARCfe4856277c6c: Add some tests for subclasses.Jun 15 2015, 10:11 AM
joshuaspence mentioned this in D13363: Modularize Celerity postprocessors.Jun 20 2015, 7:56 AM

Revision Contents
Changeset List

PathSize
src/
46 lines
applications/
almanac/
servicetype/
__tests__/
10 lines
auth/
factor/
__tests__/
10 lines
base/
__tests__/
10 lines
celerity/
resources/
1 line
__tests__/
10 lines
conduit/
method/
12 lines
__tests__/
10 lines
config/
check/
8 lines
__tests__/
10 lines
drydock/
blueprint/
__tests__/
10 lines
fact/
engine/
__tests__/
10 lines
files/
engine/
__tests__/
10 lines
transform/
__tests__/
10 lines
harbormaster/
step/
__tests__/
11 lines
maniphest/
export/
__tests__/
10 lines
meta/
panel/
__tests__/
11 lines
metamta/
command/
__tests__/
10 lines
nuance/
source/
__tests__/
10 lines
passphrase/
credentialtype/
__tests__/
10 lines
phid/
type/
2 lines
__tests__/
10 lines
phortune/
provider/
__tests__/
10 lines
policy/
capability/
__tests__/
11 lines
search/
engine/
__tests__/
11 lines
10 lines
infrastructure/
edges/
type/
__tests__/
10 lines
util/
password/
__tests__/
15 lines
10 lines

Diff 32071

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/servicetype/__tests__/AlmanacServiceTypeTestCase.php

Loading...
View Options

src/applications/auth/factor/__tests__/PhabricatorAuthFactorTestCase.php

Loading...
View Options

src/applications/base/__tests__/PhabricatorApplicationTestCase.php

Loading...
View Options

src/applications/celerity/resources/CelerityPhysicalResources.php

Loading...
View Options

src/applications/celerity/resources/__tests__/CelerityPhysicalResourcesTestCase.php

Loading...
View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/method/__tests__/ConduitAPIMethodTestCase.php

Loading...
View Options

src/applications/config/check/PhabricatorSetupCheck.php

Loading...
View Options

src/applications/config/check/__tests__/PhabricatorSetupCheckTestCase.php

Loading...
View Options

src/applications/drydock/blueprint/__tests__/DrydockBlueprintImplementationTestCase.php

Loading...
View Options

src/applications/fact/engine/__tests__/PhabricatorFactEngineTestCase.php

Loading...
View Options

src/applications/files/engine/__tests__/PhabricatorFileStorageEngineTestCase.php

Loading...
View Options

src/applications/files/transform/__tests__/PhabricatorFileTransformTestCase.php

Loading...
View Options

src/applications/harbormaster/step/__tests__/HarbormasterBuildStepImplementationTestCase.php

Loading...
View Options

src/applications/maniphest/export/__tests__/ManiphestExcelFormatTestCase.php

Loading...
View Options

src/applications/meta/panel/__tests__/PhabricatorApplicationConfigurationPanelTestCase.php

Loading...
View Options

src/applications/metamta/command/__tests__/MetaMTAEmailTransactionCommandTestCase.php

Loading...
View Options

src/applications/nuance/source/__tests__/NuanceSourceDefinitionTestCase.php

Loading...
View Options

src/applications/passphrase/credentialtype/__tests__/PassphraseCredentialTypeTestCase.php

Loading...
View Options

src/applications/phid/type/PhabricatorPHIDType.php

Loading...
View Options

src/applications/phid/type/__tests__/PhabricatorPHIDTypeTestCase.php

Loading...
View Options

src/applications/phortune/provider/__tests__/PhortunePaymentProviderTestCase.php

Loading...
View Options

src/applications/policy/capability/__tests__/PhabricatorPolicyCapabilityTestCase.php

Loading...
View Options

src/applications/search/engine/__tests__/PhabricatorApplicationSearchEngineTestCase.php

Loading...
View Options

src/applications/search/engine/__tests__/PhabricatorSearchEngineTestCase.php

Loading...
View Options

src/infrastructure/edges/type/__tests__/PhabricatorEdgeTypeTestCase.php

Loading...
View Options

src/infrastructure/util/password/__tests__/PhabricatorIteratedMD5PasswordHasherTestCase.php

Loading...
View Options

src/infrastructure/util/password/__tests__/PhabricatorPasswordHasherTestCase.php

Loading...
Phabricator · Built by Phacility