Page MenuHomePhabricator
Differential D13258

Add a "Thread Members" object policy and some unit tests
ClosedPublic
Actions

Authored by epriestley on Jun 11 2015, 11:52 PM.

Details

Reviewers
btrahan
Maniphest Tasks
T5681: Allow applications to provide custom policy rules
T8488: Remove "room" vs "message" distinction
Commits
Restricted Diffusion Commit
rP893c7a26c196: Add a "Thread Members" object policy and some unit tests
Summary

Ref T8488. Ref T5681.

Now you can just use id(new ConpherenceThreadMembersPolicyRule())->getObjectPolicyFullKey() as a policy.

Added tests for TaskAuthor + ThreadMembers.

Test Plan
  • Ran tests.
  • Set a thread policy to "Members of thread'.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32045.Jun 11 2015, 11:52 PM
epriestley retitled this revision from to Add a "Thread Members" object policy and some unit tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8488: Remove "room" vs "message" distinction, T5681: Allow applications to provide custom policy rules.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2015, 11:52 PM
btrahan accepted this revision.Jun 12 2015, 2:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2015, 2:26 PM
Closed by commit rP893c7a26c196: Add a "Thread Members" object policy and some unit tests (authored by epriestley, committed by epriestley). · Explain WhyJun 13 2015, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
conpherence/
policyrule/
42 lines
policy/
__tests__/
59 lines
query/
2 lines
rule/
14 lines

Diff 32081

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/policyrule/ConpherenceThreadMembersPolicyRule.php

Loading...
View Options

src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRule.php

Loading...
Phabricator · Built by Phacility