Paths

Table of Contentst

Differential D13220

Try using a less-rich but less-risky thread title in Conpherence handles
ClosedPublic
Actions

Authored by epriestley on Jun 9 2015, 1:38 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T8478: Loading Conpherence handles may recurse indefinitely

Commits

Restricted Diffusion Commit
rP5397779ee248: Try using a less-rich but less-risky thread title in Conpherence handles

Summary

Ref T8478. This is easier than I thought, let's see if it's conspicious?

Test Plan

Embedded {Z2} and saw "Private Correspondence".
Still saw normal stuff with useful participant lists/titles in all main UIs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31957.Jun 9 2015, 1:38 AM

epriestley retitled this revision from to Try using a less-rich but less-risky thread title in Conpherence handles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8478: Loading Conpherence handles may recurse indefinitely.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 9 2015, 1:38 AM

btrahan accepted this revision.Jun 9 2015, 2:09 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2015, 2:09 AM

Closed by commit rP5397779ee248: Try using a less-rich but less-risky thread title in Conpherence handles (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2015, 12:50 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in T8488: Remove "room" vs "message" distinction.Jun 9 2015, 6:37 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

phid/

PhabricatorConpherenceThreadPHIDType.php

4 lines

storage/

ConpherenceThread.php

17 lines

Diff 31963

View Options

src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php