Page MenuHomePhabricator
Differential D13220

Try using a less-rich but less-risky thread title in Conpherence handles
ClosedPublic
Actions

Authored by epriestley on Jun 9 2015, 1:38 AM.
Tags
None
Referenced Files
F13225424: D13220.diff
Sun, May 19, 3:09 PM
F13216475: D13220.id.diff
Sat, May 18, 1:07 AM
F13215753: D13220.id31957.diff
Fri, May 17, 7:41 PM
F13194779: D13220.diff
Sun, May 12, 9:52 PM
F13177523: D13220.diff
Wed, May 8, 7:46 PM
Unknown Object (File)
Mon, Apr 29, 3:30 PM
Unknown Object (File)
Wed, Apr 24, 11:29 PM
Unknown Object (File)
Apr 11 2024, 7:55 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8478: Loading Conpherence handles may recurse indefinitely
Commits
Restricted Diffusion Commit
rP5397779ee248: Try using a less-rich but less-risky thread title in Conpherence handles
Summary

Ref T8478. This is easier than I thought, let's see if it's conspicious?

Test Plan
  • Embedded {Z2} and saw "Private Correspondence".
  • Still saw normal stuff with useful participant lists/titles in all main UIs.

Diff Detail

Repository
rP Phabricator
Branch
private1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6639
Build 6661: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31957.Jun 9 2015, 1:38 AM
epriestley retitled this revision from to Try using a less-rich but less-risky thread title in Conpherence handles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8478: Loading Conpherence handles may recurse indefinitely.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 9 2015, 1:38 AM
btrahan accepted this revision.Jun 9 2015, 2:09 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2015, 2:09 AM
Closed by commit rP5397779ee248: Try using a less-rich but less-risky thread title in Conpherence handles (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2015, 12:50 PM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in T8488: Remove "room" vs "message" distinction.Jun 9 2015, 6:37 PM

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
phid/
4 lines
storage/
17 lines

Diff 31957

View Options

src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
Phabricator · Built by Phacility