Page MenuHomePhabricator

Conpherence - fix durable column message duplicating bug
ClosedPublic

Authored by btrahan on Jun 8 2015, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:18 AM
Unknown Object (File)
Tue, Apr 16, 3:04 PM
Unknown Object (File)
Thu, Apr 4, 8:32 PM
Unknown Object (File)
Mar 1 2024, 3:25 PM
Unknown Object (File)
Feb 6 2024, 5:02 PM
Unknown Object (File)
Jan 24 2024, 2:06 AM
Unknown Object (File)
Jan 23 2024, 12:54 AM
Unknown Object (File)
Jan 22 2024, 11:44 PM
Subscribers

Details

Summary

Fixes T6713. Though I've said that before. =D Looks like this handler wasn't upgraded earlier and was still updating the DOM; removing the DOM updating code and let the central spot handle everything and this works fine.

Test Plan

open up two browsers with durable column on same room. send messages in browser a and observe 1 copy of each message showing up in browser b. send messages in browswer b and observe one copy in browser a. browser a was chrome and browser b was firefox.

Diff Detail

Repository
rP Phabricator
Branch
conph9999
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6630
Build 6652: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - fix durable column message duplicating bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 9:12 PM
This revision was automatically updated to reflect the committed changes.