Correctly display event id and sequence in crumb and page title on eventviewcontroller
ClosedPublic
Actions

Authored by lpriestley on Jun 8 2015, 5:44 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8459: Recurring event crumbs should correctly reflect the "id" of the event - recurring, ghost, or ghost exception.

Commits

Restricted Diffusion Commit
rP973101cae6c7: Correctly display event id and sequence in crumb and page title on…

Summary

Fixes T8459, Correctly display event id and sequence in crumb and page title on eventviewcontroller

Test Plan

Open E111/3, crumb and title should display 'E111 (3)' instead of 'E111'.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31924.Jun 8 2015, 5:44 PM

lpriestley retitled this revision from to Correctly display event id and sequence in crumb and page title on eventviewcontroller.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8459: Recurring event crumbs should correctly reflect the "id" of the event - recurring, ghost, or ghost exception..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 8 2015, 5:44 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 8 2015, 5:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 5:45 PM

Closed by commit rP973101cae6c7: Correctly display event id and sequence in crumb and page title on… (authored by lpriestley, committed by lpriestley). · Explain WhyJun 8 2015, 6:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

17 lines

Diff 31927

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Correctly display event id and sequence in crumb and page title on eventviewcontrollerClosedPublicActions