Page MenuHomePhabricator

Make Subscribers automatically provide working SearchFields
ClosedPublic

Authored by epriestley on Jun 7 2015, 5:30 PM.
Tags
None
Referenced Files
F14360550: D13191.diff
Fri, Dec 20, 10:24 AM
Unknown Object (File)
Tue, Dec 17, 6:10 PM
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 8:31 AM
Unknown Object (File)
Fri, Dec 13, 5:18 AM
Unknown Object (File)
Wed, Dec 4, 5:52 AM
Subscribers
Tokens
"Haypence" token, awarded by btrahan.

Details

Summary

Ref T8441. Ref T7715. For modern Query classes, automatically make subscriber queries and SearchField integrations work.

In particular, we can just drive this query with EdgeLogic and don't need to do anything specific on these Query classes beyond making sure they're implemented in a way that picks up all of the EdgeLogic clauses.

Test Plan
  • Searched for subscribers in Pholio, Files, Paste, and Projects.
  • Searched for all other fields in Projects to check that Query changes are OK.

Diff Detail

Repository
rP Phabricator
Branch
spaces6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6605
Build 6627: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make Subscribers automatically provide working SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan awarded a token.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 6:34 PM
This revision was automatically updated to reflect the committed changes.