Differential D13017

Use file.allocate to upload large files from `arc diff`
ClosedPublic
Actions

Authored by epriestley on May 26 2015, 3:57 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8259: `arc diff` doesn't use chunked uploads

Commits

rARC5c7b22e620f8: Use file.allocate to upload large files from `arc diff`

Summary

Fixes T8259. Depends on D13016. Use modern logic to support large file uploads.

Test Plan

Diffed with some images, saw them show up in the diff.
Diffed with a 12MB binary, saw it upload in chunks.

Diff Detail

Repository

rARC Arcanist

Branch

upload2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6285
Build 6307: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31398.May 26 2015, 3:57 PM

epriestley retitled this revision from to Use file.allocate to upload large files from `arc diff`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8259: `arc diff` doesn't use chunked uploads.

epriestley added a parent revision: D13016: Move Conduit file upload logic into a separate class.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 26 2015, 3:57 PM

btrahan accepted this revision.May 27 2015, 5:04 PM

btrahan awarded a token.

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 27 2015, 5:05 PM

Closed by commit rARC5c7b22e620f8: Use file.allocate to upload large files from `arc diff` (authored by epriestley, committed by epriestley). · Explain WhyMay 27 2015, 5:26 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17618: Deprecate "file.uploadhash".Apr 4 2017, 9:40 PM

epriestley mentioned this in rP1e181f0781ca: Deprecate "file.uploadhash".Apr 4 2017, 11:18 PM

Revision Contents
Changeset List

Path

Size

src/

upload/

ArcanistFileUploader.php

26 lines

workflow/

ArcanistDiffWorkflow.php

87 lines

Diff 31398

View Options

src/upload/ArcanistFileUploader.php