Page MenuHomePhabricator

[Redesign] PHUICrumbs touchups
ClosedPublic

Authored by chad on May 20 2015, 10:37 PM.
Tags
None
Referenced Files
F15292757: D12959.id31279.diff
Wed, Mar 5, 2:54 AM
F15292756: D12959.id31213.diff
Wed, Mar 5, 2:53 AM
Unknown Object (File)
Tue, Feb 25, 9:56 AM
Unknown Object (File)
Thu, Feb 13, 9:13 PM
Unknown Object (File)
Tue, Feb 11, 9:13 PM
Unknown Object (File)
Sun, Feb 9, 3:24 AM
Unknown Object (File)
Sat, Feb 8, 4:47 AM
Unknown Object (File)
Wed, Feb 5, 6:45 AM
Subscribers

Details

Summary

Ref T8099, minor adds back the border, makes blue highlight {$blue}

Test Plan

Hover over new crumbs, match header hovers. Check Phriction for border

Diff Detail

Repository
rP Phabricator
Branch
phui-crumbs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6169
Build 6190: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to [Redesign] PHUICrumbs touchups.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

needs further testing.

  • Remove borders where AphrontListView displays
  • Fix header hover
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2015, 7:48 PM
This revision was automatically updated to reflect the committed changes.