Page MenuHomePhabricator
Differential D12959

[Redesign] PHUICrumbs touchups
ClosedPublic
Actions

Authored by chad on May 20 2015, 10:37 PM.
Tags
None
Referenced Files
F15469700: D12959.id31279.diff
Fri, Apr 4, 3:44 PM
F15462388: D12959.id31215.diff
Tue, Apr 1, 2:49 PM
F15457548: D12959.id31213.diff
Sun, Mar 30, 5:16 PM
F15457546: D12959.id31215.diff
Sun, Mar 30, 5:16 PM
F15457544: D12959.id31214.diff
Sun, Mar 30, 5:16 PM
F15457542: D12959.id31279.diff
Sun, Mar 30, 5:16 PM
F15455491: D12959.id31281.diff
Sun, Mar 30, 12:48 AM
F15446905: D12959.id.diff
Thu, Mar 27, 8:46 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP11ed4e4f2146: [Redesign] PHUICrumbs touchups
Summary

Ref T8099, minor adds back the border, makes blue highlight {$blue}

Test Plan

Hover over new crumbs, match header hovers. Check Phriction for border

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31213.May 20 2015, 10:37 PM
chad retitled this revision from to [Redesign] PHUICrumbs touchups.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 20 2015, 10:37 PM
chad planned changes to this revision.May 20 2015, 10:39 PM

needs further testing.

chad updated this revision to Diff 31214.May 20 2015, 10:57 PM
  • Remove borders where AphrontListView displays
  • Fix header hover
chad updated this revision to Diff 31215.May 20 2015, 11:30 PM
  • Fix UIExamples
chad updated this revision to Diff 31279.May 22 2015, 3:37 PM

Rebase

epriestley accepted this revision.May 22 2015, 7:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2015, 7:48 PM
Closed by commit rP11ed4e4f2146: [Redesign] PHUICrumbs touchups (authored by chad, committed by chad). · Explain WhyMay 22 2015, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
chatlog/
controller/
1 line
maniphest/
controller/
1 line
owners/
controller/
1 line
search/
controller/
1 line
uiexample/
controller/
11 lines
examples/
2 lines
webroot/
rsrc/
css/
application/
base/
2 lines
phui/
6 lines

Diff 31281

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersListController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorSortTableUIExample.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-crumbs-view.css

Loading...
Phabricator · Built by Phacility