Page MenuHomePhabricator
Differential D12954

Make default start value of new events to be the next whole hour and the end value to be the next whole hour after that.
ClosedPublic
Actions

Authored by lpriestley on May 20 2015, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 11:57 PM
Unknown Object (File)
Sun, Dec 8, 2:04 AM
Unknown Object (File)
Sat, Dec 7, 1:24 AM
Unknown Object (File)
Mon, Dec 2, 9:27 PM
Unknown Object (File)
Sat, Nov 30, 9:38 AM
Unknown Object (File)
Sat, Nov 30, 8:25 AM
Unknown Object (File)
Thu, Nov 28, 12:28 AM
Unknown Object (File)
Wed, Nov 27, 10:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8031: Set better start and end time defaults for new Calendar events.
Commits
Restricted Diffusion Commit
rPbb0004fd41bc: Make default start value of new events to be the next whole hour and the end…
Summary

Ref T8031, Make default start value of new events to be the next whole hour and the end value to be the next whole hour after that.

Test Plan

Create new event at, say, 10:30am. Event default times should be 11:00 AM - 12:00 PM

Diff Detail

Repository
rP Phabricator
Branch
calendareventdefaulttimes
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6159
Build 6180: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31195.May 20 2015, 5:28 PM
lpriestley retitled this revision from to Make default start value of new events to be the next whole hour and the end value to be the next whole hour after that..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8031: Set better start and end time defaults for new Calendar events..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 20 2015, 5:28 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 20 2015, 5:55 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2015, 5:55 PM
epriestley added a comment.May 20 2015, 5:57 PM

As an idle thought, the chance that these times are correct might actually be lower than just always picking, say, 12PM - 1PM, since the number of events scheduled less than 59 minutes in advance is probably not very large.

lpriestley added a comment.May 20 2015, 5:59 PM

Okay, I think that you're probably correct. I still think this is more useful than rightNow() - rightNow(). But yeah, maybe 12-1 is better.

Closed by commit rPbb0004fd41bc: Make default start value of new events to be the next whole hour and the end… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 20 2015, 5:59 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 20 2015, 6:26 PM

I do think this looks/feels like a better default than right now - right now, even if it's not actually more useful.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
22 lines

Diff 31195

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
Phabricator · Built by Phacility