Page MenuHomePhabricator

Time control typeaheads.
ClosedPublic

Authored by lpriestley on May 20 2015, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:23 PM
Unknown Object (File)
Wed, Dec 11, 10:55 AM
Unknown Object (File)
Thu, Nov 28, 4:13 AM
Unknown Object (File)
Nov 12 2024, 1:29 PM
Unknown Object (File)
Oct 26 2024, 1:15 AM
Unknown Object (File)
Oct 18 2024, 11:38 AM
Unknown Object (File)
Oct 11 2024, 11:53 PM
Unknown Object (File)
Oct 11 2024, 11:53 PM
Subscribers

Details

Summary

Ref T8031, Time control typeaheads

Test Plan

Edit an event, type '3', typeahead should suggest, '3:00 AM', '3:30 AM', '3:00 PM', '3:30 PM'.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Time control typeaheads..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
epriestley edited edge metadata.
epriestley added inline comments.
src/view/form/control/AphrontFormDateControl.php
385–388

If you type "1", this might sort "1 AM" before "12 AM" now, which is maybe-questionable?

This revision is now accepted and ready to land.May 20 2015, 4:20 PM
src/view/form/control/AphrontFormDateControl.php
385–388

Lolz. I forgot 12 altogether, huh.

lpriestley edited edge metadata.

Adding 12 back in the mix

This revision was automatically updated to reflect the committed changes.