Differential D12936

Maniphest + Differential - don't show transaction preview until user interacts with the form.
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 8:29 PM.

Tags

None

Referenced Files

	F14018228: D12936.diff
	Tue, Nov 5, 6:37 AM

	F14011484: D12936.diff
	Fri, Nov 1, 2:13 AM

	Unknown Object (File)
	Sep 17 2024, 8:17 AM

	Unknown Object (File)
	Sep 15 2024, 12:09 PM

	Unknown Object (File)
	Sep 10 2024, 4:04 PM

	Unknown Object (File)
	Sep 9 2024, 8:18 PM

	Unknown Object (File)
	Sep 5 2024, 4:37 AM

	Unknown Object (File)
	Sep 4 2024, 8:11 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4846: "(user) added a comment." appended before the user adds any comment

Commits

Restricted Diffusion Commit
rP9de39c12a2b4: Maniphest + Differential - don't show transaction preview until user…

Summary

Fixes T4846. These are one off (for now) since they have various crazy actions with them. I think this will get unified and more cleaned up when we refine the UI for taking multiple actions at once, etc.

Test Plan

noted no "commented on x" in either maniphest or differential. starting making a comment and noted prevew showed. started adding a subscriber (added to tokenizer) and preview showed.

Diff Detail

Repository

Branch

T4846

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6133
Build 6154: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31139.May 19 2015, 8:29 PM

btrahan added a task: T4846: "(user) added a comment." appended before the user adds any comment.

btrahan retitled this revision from to Maniphest + Differential - don't show transaction preview until user interacts with the form..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 8:29 PM

epriestley accepted this revision.May 19 2015, 11:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 11:06 PM

Closed by commit rP9de39c12a2b4: Maniphest + Differential - don't show transaction preview until user… (authored by btrahan, committed by btrahan). · Explain WhyMay 20 2015, 8:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

44 lines

webroot/

rsrc/

js/

application/

differential/

behavior-comment-preview.js

23 lines

maniphest/

behavior-transaction-preview.js

18 lines

Diff 31139

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/differential/behavior-comment-preview.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-transaction-preview.js

Loading...