Conpherence - make solo conversations be titled with viewer's name
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 7:57 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T8251: Conversation with myself doesn't list myself

Commits

Restricted Diffusion Commit
rP596db64ee62c: Conpherence - make solo conversations be titled with viewer's name

Summary

Fixes T8251. I think this used to be "lucky handle" when it was all one giant terrible function, so restore previous functionality and have the title be the viewer's name in this case.

Test Plan

rocked a solo conpherence and saw my username as the title

Diff Detail

Repository

rP Phabricator

Branch

T8251

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6131
Build 6152: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31134.May 19 2015, 7:57 PM

btrahan added a task: T8251: Conversation with myself doesn't list myself.

btrahan retitled this revision from to Conpherence - make solo conversations be titled with viewer's name.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 7:57 PM

epriestley accepted this revision.May 19 2015, 8:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 8:12 PM

Closed by commit rP596db64ee62c: Conpherence - make solo conversations be titled with viewer's name (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 8:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

storage/

ConpherenceThread.php

11 lines

Diff 31134

View Options

src/applications/conpherence/storage/ConpherenceThread.php

Conpherence - make solo conversations be titled with viewer's nameClosedPublicActions