Page MenuHomePhabricator

Filter pastes at the query level if we're unable to load their content
ClosedPublic

Authored by epriestley on May 18 2015, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 11:16 AM
Unknown Object (File)
Tue, Dec 17, 10:39 AM
Unknown Object (File)
Tue, Dec 17, 6:09 AM
Unknown Object (File)
Tue, Dec 17, 4:08 AM
Unknown Object (File)
Wed, Dec 4, 3:21 AM
Unknown Object (File)
Mon, Dec 2, 10:11 AM
Unknown Object (File)
Mon, Dec 2, 5:54 AM
Unknown Object (File)
Mon, Dec 2, 5:54 AM
Subscribers

Details

Summary

Fixes T8230. I think I broke this in D12354 since I missed the fact that this could filter results, because it's constructed in a sort of weird way. Try to make the logic a little more clear, while retaining the relevant properties:

  • Pastes with unloadable content should be discarded;
  • the input order should be retained in the result set.
Test Plan

Faked content misses and saw things work instead of fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Filter pastes at the query level if we're unable to load their content.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 8:07 PM
This revision was automatically updated to reflect the committed changes.