Page MenuHomePhabricator
Differential D12898

Remove "arcanist projects" from Releeph
ClosedPublic
Actions

Authored by joshuaspence on May 18 2015, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:21 PM
Unknown Object (File)
Fri, Dec 13, 9:43 PM
Unknown Object (File)
Mon, Dec 9, 3:50 PM
Unknown Object (File)
Sun, Dec 8, 8:29 PM
Unknown Object (File)
Thu, Dec 5, 12:17 PM
Unknown Object (File)
Thu, Dec 5, 12:17 PM
Unknown Object (File)
Thu, Dec 5, 3:29 AM
Unknown Object (File)
Tue, Dec 3, 2:03 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Commits
Restricted Diffusion Commit
rP205adbdda179: Remove "arcanist projects" from Releeph
Summary

Ref T7604. Remove arcanist projects from Releeph.

Test Plan

I don't really know how to use Releeph but I clicked around and nothing seemed too broken.

Diff Detail

Repository
rP Phabricator
Branch
arpj5
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/releeph/controller/product/ReleephProductEditController.php:95TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 6063
Build 6083: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31022.May 18 2015, 1:39 PM
joshuaspence retitled this revision from to Remove arcanist projects from Releeph.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7604: Remove "Arcanist Projects".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2015, 1:39 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a comment.May 18 2015, 2:23 PM

I really have no idea how to test this stuff.

joshuaspence added a child revision: D12897: Remove "arcanist project" controllers.May 18 2015, 2:31 PM
joshuaspence added a child revision: D12899: Remove remaining arcanist project code.May 18 2015, 2:34 PM
joshuaspence updated this revision to Diff 31230.May 21 2015, 11:47 AM
joshuaspence edited edge metadata.

Add migration

joshuaspence retitled this revision from Remove arcanist projects from Releeph to Remove "arcanist projects" from Releeph.May 21 2015, 11:49 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence updated this revision to Diff 31341.May 25 2015, 11:48 AM

Rebase

epriestley accepted this revision.May 25 2015, 2:33 PM
epriestley edited edge metadata.

¯\_(ツ)_/¯

This revision is now accepted and ready to land.May 25 2015, 2:33 PM
Closed by commit rP205adbdda179: Remove "arcanist projects" from Releeph (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D13012: Remove "arcanist project" fields.May 25 2015, 9:23 PM

Revision Contents
Changeset List

Diff 31022

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchNamePreviewController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductCreateController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductEditController.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php

Loading...
View Options

src/applications/releeph/query/ReleephProductQuery.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/view/branch/ReleephBranchTemplate.php

Loading...
Phabricator · Built by Phacility