Page MenuHomePhabricator
Differential D12897

Remove "arcanist project" controllers
ClosedPublic
Actions

Authored by joshuaspence on May 18 2015, 1:26 PM.
Tags
None
Referenced Files
F14413528: D12897.diff
Tue, Dec 24, 2:22 PM
Unknown Object (File)
Sat, Dec 21, 2:20 PM
Unknown Object (File)
Fri, Dec 20, 9:24 PM
Unknown Object (File)
Thu, Dec 19, 4:10 PM
Unknown Object (File)
Wed, Dec 18, 3:19 PM
Unknown Object (File)
Fri, Dec 13, 10:52 AM
Unknown Object (File)
Mon, Dec 9, 12:00 PM
Unknown Object (File)
Sat, Dec 7, 7:56 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7603: Remove the deprecated "Repositories" application
T7604: Remove "Arcanist Projects"
Commits
Restricted Diffusion Commit
rP6e5e6a1a8c31: Remove "arcanist project" controllers
Summary

Ref T7603. Ref T7604. There is no need for these controllers anymore as the "Arcanist Project" data is not used anywhere. Depends on D12894 and D12898.

Test Plan

Went to /repository/project/edit/2/ and got a 404.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6245
Build 6267: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31021.May 18 2015, 1:26 PM
joshuaspence retitled this revision from to Remove arcanits project controllers.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a task: T7604: Remove "Arcanist Projects".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2015, 1:26 PM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence retitled this revision from Remove arcanits project controllers to Remove "arcanist project" controllers.May 18 2015, 2:23 PM
joshuaspence edited edge metadata.
joshuaspence updated this object.
joshuaspence added a parent revision: D12894: Remove arcanist projects from differential.
joshuaspence updated this object.May 18 2015, 2:30 PM
joshuaspence updated this object.
joshuaspence added a parent revision: D12898: Remove "arcanist projects" from Releeph.
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.May 18 2015, 2:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 2:33 PM
joshuaspence added a child revision: D12899: Remove remaining arcanist project code.May 18 2015, 2:34 PM
joshuaspence updated this revision to Diff 31180.May 20 2015, 1:47 AM
joshuaspence edited edge metadata.

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2015, 1:47 AM
joshuaspence edited the test plan for this revision. (Show Details)May 25 2015, 10:56 AM
joshuaspence updated this revision to Diff 31329.May 25 2015, 10:56 AM
joshuaspence edited the test plan for this revision. (Show Details)

Rebase

joshuaspence edited the test plan for this revision. (Show Details)May 25 2015, 10:56 AM
joshuaspence updated this object.
joshuaspence added a task: T7603: Remove the deprecated "Repositories" application.
Closed by commit rP6e5e6a1a8c31: Remove "arcanist project" controllers (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31329

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/application/PhabricatorRepositoriesApplication.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryListController.php

Loading...
Phabricator · Built by Phacility