Page MenuHomePhabricator
Differential D12873

[Redesign] Convert Dashboard Panels to ObjectBox
ClosedPublic
Actions

Authored by chad on May 16 2015, 2:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 8:51 AM
Unknown Object (File)
Thu, Nov 28, 2:32 AM
Unknown Object (File)
Mon, Nov 25, 7:50 PM
Unknown Object (File)
Wed, Nov 20, 4:27 AM
Unknown Object (File)
Nov 16 2024, 11:08 AM
Unknown Object (File)
Nov 12 2024, 1:39 PM
Unknown Object (File)
Nov 12 2024, 3:10 AM
Unknown Object (File)
Nov 8 2024, 12:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP490a6fe8b1ac: [Redesign] Convert Dashboard Panels to ObjectBox
Summary

Moves Dashboard Panels to use PHUIObjectBoxView and PHUIHeaderView

Test Plan

Tested the most common dashboards, Differential, Maniphest, Projects, Feed, Audit. Some edge cases (Legalpad, Macro) still are in progress. Tested laying out a new Dashboard, removing panels, moving panels.

pasted_file (299×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Branch
dashboard-object-box
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6028
Build 6048: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30963.May 16 2015, 2:24 AM
chad retitled this revision from to [Redesign] Convert Dashboard Panels to ObjectBox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 16 2015, 2:24 AM
chad added a task: T8099: Mid-2015 Phabricator Redesign.May 16 2015, 2:24 AM
chad edited the test plan for this revision. (Show Details)
chad added a comment.May 16 2015, 2:29 AM

I should in the next diff or two, be able to remove PHUIActionHeaderView

epriestley accepted this revision.May 17 2015, 12:55 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 12:55 PM
Closed by commit rP490a6fe8b1ac: [Redesign] Convert Dashboard Panels to ObjectBox (authored by chad, committed by chad). · Explain WhyMay 17 2015, 2:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
celerity/
1 line
dashboard/
engine/
48 lines
paneltype/
2 lines
8 lines
view/
phui/
25 lines
2 lines
webroot/
rsrc/
css/
application/
dashboard/
20 lines
feed/
30 lines
phui/
21 lines
4 lines
9 lines
1 line
30 lines
90 lines

Diff 30963

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/CelerityResourceTransformer.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
View Options

webroot/rsrc/css/application/feed/feed.css

Loading...
View Options

webroot/rsrc/css/phui/phui-action-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility