Page MenuHomePhabricator
Differential D12858

Don't use handles in the Calendar event name migration
ClosedPublic
Actions

Authored by epriestley on May 15 2015, 12:46 PM.
Tags
None
Referenced Files
F14347155: D12858.diff
Thu, Dec 19, 2:51 AM
Unknown Object (File)
Fri, Dec 6, 7:18 AM
Unknown Object (File)
Tue, Nov 26, 10:38 PM
Unknown Object (File)
Fri, Nov 22, 7:36 PM
Unknown Object (File)
Fri, Nov 22, 4:19 PM
Unknown Object (File)
Wed, Nov 20, 9:35 AM
Unknown Object (File)
Nov 18 2024, 4:24 PM
Unknown Object (File)
Nov 18 2024, 9:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8209: Migrations which use handles may fail after introduction of cache columns
Commits
Restricted Diffusion Commit
rP27b78d214790: Don't use handles in the Calendar event name migration
Summary

Fixes T8209. Using handles can now cause cache fills as a side effect of T7707. Use a raw query instead.

I'll follow up on T8209 with some context and ideas for longer-term fixes.

Test Plan
  • Set event names to ''.
  • Reran migration with --apply ... --trace.
  • Saw migration work correctly without executing cache fills.

Diff Detail

Repository
rP Phabricator
Branch
calmig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6006
Build 6026: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30928.May 15 2015, 12:46 PM
epriestley retitled this revision from to Don't use handles in the Calendar event name migration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8209: Migrations which use handles may fail after introduction of cache columns.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2015, 12:46 PM
epriestley added a comment.May 15 2015, 12:54 PM

Some discussion in T4571. Notably, this is the only migration where we access handles.

btrahan accepted this revision.May 15 2015, 6:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 15 2015, 6:29 PM
Closed by commit rP27b78d214790: Don't use handles in the Calendar event name migration (authored by epriestley, committed by epriestley). · Explain WhyMay 15 2015, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
11 lines

Diff 30928

View Options

resources/sql/autopatches/20150506.calendarunnamedevents.1.php

Loading...
Phabricator · Built by Phacility