Differential D12812

Implement error-checked "preview" transforms
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 6:21 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7707: Implement a read-through cache layer

Commits

Restricted Diffusion Commit
rPfd1e0bc4d302: Implement error-checked "preview" transforms

Summary

Ref T7707. These transforms have a single maximum dimension instead of fixed X and Y dimensions.

Test Plan

Transformed a bunch of files with different sizes/aspect ratios, got sensible results.

Diff Detail

Repository

rP Phabricator

Branch

fxform6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5923
Build 5943: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30790.May 12 2015, 6:21 PM

epriestley retitled this revision from to Implement error-checked "preview" transforms.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7707: Implement a read-through cache layer.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2015, 6:21 PM

btrahan accepted this revision.May 12 2015, 6:34 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2015, 6:34 PM

Closed by commit rPfd1e0bc4d302: Implement error-checked "preview" transforms (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

transform/

PhabricatorFileImageTransform.php

7 lines

PhabricatorFileThumbnailTransform.php

68 lines

Diff 30790

View Options

src/applications/files/transform/PhabricatorFileImageTransform.php