Paths

Table of Contentst

Differential D12805

Use `CLASS` instead of hardcoding class names
ClosedPublic
Actions

Authored by joshuaspence on May 12 2015, 12:35 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC3ae1fed4f914: Use `__CLASS__` instead of hardcoding class names

Summary

Use __CLASS__ instead of hardcoding class names. Depends on D12804.

Test Plan

Eyeball it.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5915
Build 5935: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30781.May 12 2015, 12:35 PM

joshuaspence retitled this revision from to Use `__CLASS__` instead of hardcoding class names.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D12804: Use `__CLASS__` instead of hardcoding class names.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:35 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D12806: Use `__CLASS__` instead of hard-coding class names.May 12 2015, 12:54 PM

joshuaspence removed a child revision: D12806: Use `__CLASS__` instead of hard-coding class names.May 12 2015, 11:48 PM

epriestley accepted this revision.May 13 2015, 2:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 13 2015, 2:54 PM

Closed by commit rARC3ae1fed4f914: Use `__CLASS__` instead of hardcoding class names (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

ArcanistLintMessage.php

2 lines

linter/

ArcanistPyLintLinter.php

11 lines

ArcanistXHPASTLinter.php

38 lines

__tests__/

xhpast/

class-name-literal.lint-test

33 lines

unit/

engine/

ArcanistUnitTestEngine.php

2 lines

PhutilUnitTestEngine.php

7 lines

workflow/

ArcanistWorkflow.php

2 lines

Diff 30781

View Options

src/lint/ArcanistLintMessage.php

View Options

src/lint/linter/ArcanistPyLintLinter.php

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/class-name-literal.lint-test

View Options

src/unit/engine/ArcanistUnitTestEngine.php

View Options

src/unit/engine/PhutilUnitTestEngine.php

View Options

src/workflow/ArcanistWorkflow.php

Use `__CLASS__` instead of hardcoding class namesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30781

src/lint/ArcanistLintMessage.php

src/lint/linter/ArcanistPyLintLinter.php

src/lint/linter/ArcanistXHPASTLinter.php

src/lint/linter/__tests__/xhpast/class-name-literal.lint-test

src/unit/engine/ArcanistUnitTestEngine.php

src/unit/engine/PhutilUnitTestEngine.php

src/workflow/ArcanistWorkflow.php

Use `CLASS` instead of hardcoding class names
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/xhpast/class-name-literal.lint-test