Closes T8085, Calendar day view and corresponding sidebar should correctly display all all-day events returned from query
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8085: Multi-day events are not being drawn on Calendar day view.
- Commits
- Restricted Diffusion Commit
rP22ac7d7c7607: Calendar day view and corresponding sidebar should correctly display all all…
Open day view with all-day and multi-day events, all events should correctly be drawn in day view in correct order, and sidebar preview should correctly mark future day boxes with all day events.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendaralldaysidebar
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5867 Build 5887: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php | ||
|---|---|---|
| 395–397 | At some point, we should probably do this as a part of the query parameters we show to the user instead, e.g. add a dropdown like: Cancelled: [ Show Only Active Events V ]
[ Show Only Cancelled Events ]
[ Show Active and Cancelled Events ]...so by default it would only show active events, but you could show or search for cancelled events if you wanted. | |
| src/view/phui/calendar/PHUICalendarDayView.php | ||
| 56 | Do we need this part (start == start)? I'd think the other part would be good enough on its own. | |
| 82 | This may not work after constraining the day's start time to 8AM. | |
| 196–198 | Does this get multi-day events which are not all-day events right? I'd expect to only need the last condition: (start < end && end > start) | |