Paths

Table of Contentst

Differential D12773

Clean up miscellaneous bot issues
ClosedPublic
Actions

Authored by epriestley on May 8 2015, 2:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 8:04 AM

	Unknown Object (File)
	Fri, May 3, 7:48 AM

	Unknown Object (File)
	Fri, May 3, 1:57 AM

	Unknown Object (File)
	Fri, Apr 26, 5:41 AM

	Unknown Object (File)
	Thu, Apr 25, 1:44 AM

	Unknown Object (File)
	Mar 30 2024, 10:22 PM

	Unknown Object (File)
	Mar 13 2024, 10:34 AM

	Unknown Object (File)
	Mar 10 2024, 2:47 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7775: PhabricatorBot calls deprecated Conduit method "diffusion.getcommits"
T6073: Bot object name handler should probably only match whole words
T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls

Commits

Restricted Diffusion Commit
rPdd88a0e9e9ea: Clean up miscellaneous bot issues

Summary

Fixes T6073. Fixes T7775. Ref T4377. This fixes a few easy things without any compatibility-breaking changes.

Stop matching things like :D123 as a revision (particularly: IPv6 addresses).
Use "diffusion.querycommits".
Support "conduit.token".

Test Plan

Used a token:

[07:52am] epriestley: -D22 :D22 #D22 /D22
[07:52am] epriestley: D22
[07:52am] phabot-local: D22: asdbb - http://local.phacility.com/D22
[07:54am] epriestley: rHGTESTX6518697472d6395f5d1cec557148957734aa76c2
[07:54am] phabot-local: http://local.phacility.com/rHGTESTX6518697472d6395f5d1cec557148957734aa76c2

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30699.May 8 2015, 2:58 PM

epriestley retitled this revision from to Clean up miscellaneous bot issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls, T6073: Bot object name handler should probably only match whole words, T7775: PhabricatorBot calls deprecated Conduit method "diffusion.getcommits".

Herald added a subscriber: epriestley. · View Herald TranscriptMay 8 2015, 2:58 PM

btrahan accepted this revision.May 8 2015, 5:53 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 5:53 PM

Closed by commit rPdd88a0e9e9ea: Clean up miscellaneous bot issues (authored by epriestley, committed by epriestley). · Explain WhyMay 8 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls.Aug 23 2016, 7:02 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

bot/

PhabricatorBot.php

30 lines

handler/

PhabricatorBotObjectNameHandler.php

17 lines

Diff 30710

src/infrastructure/daemon/bot/PhabricatorBot.php

Loading...

src/infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php

Loading...