Invitee list on Calendar event detail view should have pretty icons
ClosedPublic
Actions

Authored by lpriestley on May 5 2015, 5:54 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8020: Invitee list should look a bit nicer

Commits

Restricted Diffusion Commit
rP3463a0d49797: Invitee list on Calendar event detail view should have pretty icons

Summary

Closes T8020, Invitee list on Calendar event detail view should have pretty icons.

Test Plan

Open event, invite users, event detail should show invitee names with blank circles, after users accept/decline, icons should update to green check/red times icons, respectively.

Diff Detail

Repository

rP Phabricator

Branch

calendareventinviteeicons

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5773
Build 5792: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30561.May 5 2015, 5:54 PM

lpriestley retitled this revision from to Invitee list on Calendar event detail view should have pretty icons.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8020: Invitee list should look a bit nicer.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 5 2015, 5:54 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 5 2015, 7:01 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php
38–52	Consider assigning only the status itself, then wrapping it in an array later.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
214–215	I lied to you about the best way to do this -- `setIcon()` takes a second "color" parameter. So these should be: ->setIcon($icon, 'green') ..etc.