Page MenuHomePhabricator
Differential D12701

Refactoring CalendarEventSearchEngine to fit new null handling of AphrontFormDateControlValue
ClosedPublic
Actions

Authored by lpriestley on May 4 2015, 6:00 PM.
Tags
None
Referenced Files
F13146764: D12701.diff
Fri, May 3, 10:22 AM
F13134510: D12701.diff
Thu, May 2, 3:27 AM
Unknown Object (File)
Thu, Apr 25, 3:49 AM
Unknown Object (File)
Sat, Apr 20, 4:24 AM
Unknown Object (File)
Sat, Apr 20, 4:24 AM
Unknown Object (File)
Sat, Apr 20, 4:19 AM
Unknown Object (File)
Sat, Apr 20, 3:40 AM
Unknown Object (File)
Sat, Apr 13, 9:36 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4393: Implement "Daily/Weekly" Calendar Mock
Commits
Restricted Diffusion Commit
rPc02db2d15cba: Refactoring CalendarEventSearchEngine to fit new null handling of…
Summary

Ref T4393, Refactoring CalendarEventSearchEngine to fit new null handling of AphrontFormDateControlValue

Test Plan

Use calendar query for day view, expect no php errors

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30495.May 4 2015, 6:00 PM
lpriestley retitled this revision from to Refactoring CalendarEventSearchEngine to fit new null handling of AphrontFormDateControlValue.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 6:00 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 4 2015, 6:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 6:05 PM
Closed by commit rPc02db2d15cba: Refactoring CalendarEventSearchEngine to fit new null handling of… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 4 2015, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
4 lines

Diff 30498

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility