Paths

Table of Contentst

Don't add resources to Multimeter when there's no multimeter running
ClosedPublic
Actions

Authored by epriestley on May 4 2015, 3:07 PM.

Details

Reviewers

joshuaspence
btrahan
chad

Maniphest Tasks

T8058: Unit tests failing at HEAD

Commits

Restricted Diffusion Commit
rP1168a8c0a014: Don't add resources to Multimeter when there's no multimeter running

Summary

Fixes T8058. Don't add a Multimeter event if we aren't running multimeter (e.g., in unit tests).

Test Plan

Will arc unit --everything.

Diff Detail

Repository

rP Phabricator

Branch

mmx

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5736
Build 5755: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30483.May 4 2015, 3:07 PM

epriestley retitled this revision from to Don't add resources to Multimeter when there's no multimeter running.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T8058: Unit tests failing at HEAD.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 4 2015, 3:07 PM

Will arc unit --everything.

Yep, fixed it.

chad accepted this revision.May 4 2015, 4:12 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.May 4 2015, 4:12 PM

Closed by commit rP1168a8c0a014: Don't add resources to Multimeter when there's no multimeter running (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

celerity/

CelerityStaticResourceResponse.php

7 lines

Diff 30483

View Options

src/applications/celerity/CelerityStaticResourceResponse.php

Don't add resources to Multimeter when there's no multimeter runningClosedPublicActions