Paths

Table of Contentst

Differential D12685

First stab at day view
ClosedPublic
Actions

Authored by lpriestley on May 3 2015, 11:41 PM.

Tags

None

Referenced Files

	F14102963: D12685.diff
	Tue, Nov 26, 8:43 PM

	Unknown Object (File)
	Sun, Nov 17, 7:58 PM

	Unknown Object (File)
	Thu, Nov 14, 5:18 AM

	Unknown Object (File)
	Mon, Nov 11, 4:24 PM

	Unknown Object (File)
	Sun, Nov 10, 1:20 AM

	Unknown Object (File)
	Wed, Nov 6, 3:25 AM

	Unknown Object (File)
	Oct 27 2024, 2:12 AM

	Unknown Object (File)
	Oct 16 2024, 9:17 AM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4393: Implement "Daily/Weekly" Calendar Mock

Commits

Restricted Diffusion Commit
rPee2af9045525: First stab at day view

Summary

Ref T4393, First stab at day view.

Test Plan

Open Calendar Advanced Search, select "Day View (beta)", see rough day view of selected day.

Diff Detail

Repository

Branch

calendarday

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5713
Build 5732: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30452.May 3 2015, 11:41 PM

lpriestley retitled this revision from to First stab at day view.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 3 2015, 11:41 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Cleanup of the obvious

epriestley accepted this revision.May 3 2015, 11:52 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
371–389	Consider removing; this is unused and colorizing based on host no longer makes sense in the product.
407–427	Per discussion, we'll merge this into `getDisplayMonthAndYear()` once the `calendarDay` stuff is fully straightened out.

This revision is now accepted and ready to land.May 3 2015, 11:52 PM

Removing "Assign colors" on calendar day view events

Closed by commit rPee2af9045525: First stab at day view (authored by lpriestley, committed by lpriestley). · Explain WhyMay 3 2015, 11:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

__phutil_library_map__.php

6 lines

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

54 lines

view/

AphrontCalendarDayEventView.php

39 lines

view/

phui/

calendar/

PHUICalendarDayView.php

131 lines

webroot/

rsrc/

css/

phui/

calendar/

phui-calendar-day.css

32 lines

Diff 30454

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...

src/applications/calendar/view/AphrontCalendarDayEventView.php

Loading...

src/view/phui/calendar/PHUICalendarDayView.php

Loading...

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...