Page MenuHomePhabricator
Differential D12670

Modernize search engine selection
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 10:36 AM.
Tags
None
Referenced Files
F13813813: D12670.id30632.diff
Thu, Sep 19, 1:16 AM
Unknown Object (File)
Thu, Sep 5, 6:27 AM
Unknown Object (File)
Wed, Aug 28, 6:50 AM
Unknown Object (File)
Aug 17 2024, 7:10 AM
Unknown Object (File)
Aug 16 2024, 12:16 PM
Unknown Object (File)
Aug 3 2024, 11:50 AM
Unknown Object (File)
Jul 31 2024, 2:34 AM
Unknown Object (File)
Jul 27 2024, 11:31 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP16a8ed72bdda: Modernize search engine selection
Summary

Remove the PhabricatorDefaultSearchEngineSelector class. This is quite similar to D12053.

Test Plan

Went to /view/PhabricatorSearchApplication/ and saw the storage engine configuration. Set search.elastic.host and saw the highlighted storage engine change.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5823
Build 5843: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30432.May 3 2015, 10:36 AM
joshuaspence retitled this revision from to Modernize search engine selection.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 10:36 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)May 5 2015, 12:56 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 30552.May 5 2015, 12:58 PM
joshuaspence edited the test plan for this revision. (Show Details)

Add PhabricatorSearchApplicationStorageEnginePanel

joshuaspence updated this revision to Diff 30632.May 7 2015, 12:51 PM

Various fixes

joshuaspence edited the test plan for this revision. (Show Details)May 7 2015, 12:54 PM
epriestley accepted this revision.May 19 2015, 2:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 2:08 PM
epriestley awarded a token.May 19 2015, 2:08 PM
Closed by commit rP16a8ed72bdda: Modernize search engine selection (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30632

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/check/PhabricatorElasticSearchSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorElasticSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...
View Options

src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/search/applicationpanel/PhabricatorSearchApplicationStorageEnginePanel.php

Loading...
View Options

src/applications/search/config/PhabricatorSearchConfigOptions.php

Loading...
View Options

src/applications/search/engine/PhabricatorElasticSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorMySQLSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorSearchEngine.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
View Options

src/applications/search/management/PhabricatorSearchManagementInitWorkflow.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchDocumentQuery.php

Loading...
View Options

src/applications/search/selector/PhabricatorDefaultSearchEngineSelector.php

Loading...
View Options

src/applications/search/selector/PhabricatorSearchEngineSelector.php

Loading...
Phabricator · Built by Phacility