Differential D12614

Restore missing ApplicationSearch join clause for Maniphest
ClosedPublic
Actions

Authored by epriestley on Apr 29 2015, 8:27 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPf3a2d2b02043: Restore missing ApplicationSearch join clause for Maniphest

Summary

See IRC. This got dropped in the order refactoring.

Test Plan

Ordered Maniphest search results by a custom field.

Diff Detail

Repository

rP Phabricator

Branch

appjoin

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5593
Build 5612: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30282.Apr 29 2015, 8:27 PM

epriestley retitled this revision from to Restore missing ApplicationSearch join clause for Maniphest.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 29 2015, 8:27 PM

btrahan accepted this revision.Apr 29 2015, 8:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2015, 8:28 PM

Closed by commit rPf3a2d2b02043: Restore missing ApplicationSearch join clause for Maniphest (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2015, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

1 line

Diff 30282

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Restore missing ApplicationSearch join clause for ManiphestClosedPublicActions