Page MenuHomePhabricator
Differential D12595

Calendar events should support subscribers, for possible future uses.
ClosedPublic
Actions

Authored by lpriestley on Apr 28 2015, 5:17 PM.
Tags
None
Referenced Files
F13818170: D12595.diff
Fri, Sep 20, 5:42 AM
Unknown Object (File)
Fri, Sep 13, 2:07 PM
Unknown Object (File)
Thu, Sep 12, 1:55 PM
Unknown Object (File)
Thu, Sep 12, 1:55 PM
Unknown Object (File)
Thu, Sep 12, 1:54 PM
Unknown Object (File)
Thu, Sep 12, 1:54 PM
Unknown Object (File)
Thu, Sep 12, 1:53 PM
Unknown Object (File)
Thu, Sep 12, 1:53 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7974: Subscribers for Calendar events.
Commits
Restricted Diffusion Commit
rPc6fa4355cc92: Calendar events should support subscribers, for possible future uses.
Summary

Closes T7974, Calendar events support subscribers.

Test Plan

Create or update calendar event, add subscribers, save, event detail view should show subscribers, and timeline should reflect the action.

Diff Detail

Repository
rP Phabricator
Branch
calendareventsubscribers
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5566
Build 5585: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30239.Apr 28 2015, 5:17 PM
lpriestley retitled this revision from to Calendar events should support subscribers, for possible future uses..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7974: Subscribers for Calendar events..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2015, 5:17 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30240.Apr 28 2015, 5:20 PM
lpriestley edited edge metadata.

Renaming cc_value to subscribers for consistency.

epriestley accepted this revision.Apr 28 2015, 5:27 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
30–31

Not used?

233–234

Unintended change?

This revision is now accepted and ready to land.Apr 28 2015, 5:27 PM
lpriestley marked 2 inline comments as done.Apr 28 2015, 5:34 PM
lpriestley added inline comments.
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
30–31

Correct. I was adding and deleting the EDGE events, so that's a remnant of that. Taking it out.

233–234

Correct.

lpriestley updated this revision to Diff 30246.Apr 28 2015, 5:35 PM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

Cleaning up transactions.

Closed by commit rPc6fa4355cc92: Calendar events should support subscribers, for possible future uses. (authored by lpriestley, committed by lpriestley). · Explain WhyApr 28 2015, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30239

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility