Page MenuHomePhabricator
Differential D12525

Use a function typeahead for "projects" in Maniphest
ClosedPublic
Actions

Authored by epriestley on Apr 23 2015, 11:00 AM.
Tags
None
Referenced Files
F15488726: D12525.id30083.diff
Fri, Apr 11, 2:00 AM
F15465434: D12525.id.diff
Wed, Apr 2, 6:36 PM
F15464017: D12525.id30083.diff
Wed, Apr 2, 5:29 AM
F15461920: D12525.id30071.diff
Tue, Apr 1, 12:20 PM
F15460221: D12525.id30071.diff
Mon, Mar 31, 9:07 PM
F15458799: D12525.diff
Mon, Mar 31, 7:26 AM
F15439958: D12525.id.diff
Wed, Mar 26, 10:32 AM
F15407853: D12525.diff
Mar 18 2025, 7:56 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rP7ab025eef559: Use a function typeahead for "projects" in Maniphest
Summary

Ref T4100. Collapse the five inputs into one.

Test Plan
  • Searched for a bunch of stuff.
  • Used "Group By: Project", which is a bit of a special case and possibly tricky.
  • Created an old query with all the fields, then updated; verified it was preserved/transformed correctly.

Screen_Shot_2015-04-23_at_3.54.13_AM.png (165×1 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
search3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/query/ManiphestTaskQuery.php:914XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5466
Build 5484: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30071.Apr 23 2015, 11:00 AM
epriestley retitled this revision from to Use a function typeahead for "projects" in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 23 2015, 11:00 AM
btrahan accepted this revision.Apr 23 2015, 5:21 PM
btrahan edited edge metadata.

setColor(null) usage is increasing...!

This revision is now accepted and ready to land.Apr 23 2015, 5:21 PM
Closed by commit rP7ab025eef559: Use a function typeahead for "projects" in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyApr 23 2015, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30071

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...
Phabricator · Built by Phacility