Page MenuHomePhabricator
Differential D12442

Make browse action available for dynamic/JS-driven tokenizers
ClosedPublic
Actions

Authored by epriestley on Apr 16 2015, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 3:55 PM
Unknown Object (File)
Nov 28 2024, 1:12 PM
Unknown Object (File)
Nov 28 2024, 1:12 PM
Unknown Object (File)
Nov 28 2024, 12:42 PM
Unknown Object (File)
Nov 28 2024, 8:43 AM
Unknown Object (File)
Nov 19 2024, 10:23 PM
Unknown Object (File)
Nov 13 2024, 9:53 PM
Unknown Object (File)
Nov 2 2024, 4:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPa4261f41c2b7: Make browse action available for dynamic/JS-driven tokenizers
Summary

Ref T5750. This makes browse work for all of the dynamic tokenizers in Herald, Policies, batch editor, etc.

Test Plan

Used tokenizers in Herald, Policies, Batch editor.

Diff Detail

Repository
rP Phabricator
Branch
type13
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php:29XHP16TODO Comment
Advicesrc/view/control/AphrontTokenizerTemplateView.php:82XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5344
Build 5362: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29858.Apr 16 2015, 9:47 PM
epriestley retitled this revision from to Make browse action available for dynamic/JS-driven tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a reviewer: chad. · View Herald TranscriptApr 16 2015, 9:47 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley added a comment.Apr 16 2015, 9:48 PM

Oh, this also fakes mailing lists so that the "Subscriber" composite source is browsable.

btrahan accepted this revision.Apr 17 2015, 5:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2015, 5:22 PM
Closed by commit rPa4261f41c2b7: Make browse action available for dynamic/JS-driven tokenizers (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
120 lines
src/
applications/
herald/
controller/
3 lines
mailinglists/
typeahead/
17 lines
maniphest/
controller/
21 lines
policy/
rule/
8 lines
10 lines
8 lines
8 lines
view/
control/
37 lines
webroot/
rsrc/
css/
aphront/
10 lines
externals/
javelin/
lib/
control/
tokenizer/
1 line
js/
application/
herald/
14 lines
maniphest/
12 lines
policy/
13 lines
core/
11 lines

Diff 29858

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/mailinglists/typeahead/PhabricatorMailingListDatasource.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorProjectsPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorUsersPolicyRule.php

Loading...
View Options

src/view/control/AphrontTokenizerTemplateView.php

Loading...
View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-batch-editor.js

Loading...
View Options

webroot/rsrc/js/application/policy/behavior-policy-rule-editor.js

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
Phabricator · Built by Phacility