Page MenuHomePhabricator
Differential D12428

Improve browsability of Projects query
ClosedPublic
Actions

Authored by epriestley on Apr 15 2015, 6:52 PM.
Tags
None
Referenced Files
F13275356: D12428.diff
Fri, May 31, 4:41 AM
F13261461: D12428.diff
Mon, May 27, 1:04 AM
F13245746: D12428.id29837.diff
Thu, May 23, 6:12 AM
F13245335: D12428.diff
Thu, May 23, 5:57 AM
F13241920: D12428.id.diff
Thu, May 23, 12:21 AM
F13241387: D12428.id29837.diff
Wed, May 22, 8:46 PM
F13240821: D12428.id.diff
Wed, May 22, 4:52 PM
F13240031: D12428.id29877.diff
Wed, May 22, 9:33 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPc8dc11d81a75: Improve browsability of Projects query
Summary

Ref T5750. Same deal as D12427, but for projects.

(As before, mostly making the empty/browse view work instead of return nothing.)

Test Plan

Screen_Shot_2015-04-15_at_11.48.11_AM.png (432×615 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Branch
type6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5329
Build 5347: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29837.Apr 15 2015, 6:52 PM
epriestley retitled this revision from to Improve browsability of Projects query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 15 2015, 6:52 PM
btrahan accepted this revision.Apr 16 2015, 4:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2015, 4:13 PM
Closed by commit rPc8dc11d81a75: Improve browsability of Projects query (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
query/
35 lines
3 lines
typeahead/
17 lines

Diff 29837

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
Phabricator · Built by Phacility