Paths

Table of Contentst

Differential D12389

Add a linter rule for declaring nested functions
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 10:50 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCe233b158f2e1: Add a linter rule for declaring nested functions

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_INNER_FUNCTION to advise against declaring PHP functions within an outer function. Based on Squiz_Sniffs_PHP_InnerFunctionsSniff.

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29735.Apr 13 2015, 10:50 AM

joshuaspence retitled this revision from to Add a linter rule for declaring nested functions.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 10:50 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Better detection of closures

"Rocks are heavy and rigid. Avoid hitting yourself in the face with a rock."

This revision is now accepted and ready to land.Apr 13 2015, 2:27 PM

Closed by commit rARCe233b158f2e1: Add a linter rule for declaring nested functions (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

27 lines

__tests__/

xhpast/

inner-function.lint-test

14 lines

Diff 29784

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/inner-function.lint-test

Add a linter rule for declaring nested functionsClosedPublicActions