Differential D12369

Trim trailing whitespace from diff hints
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 11:37 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCbf1b30ae2635: Trim trailing whitespace from diff hints

Summary

Although these don't do any harm, they show up in my editor which is configured to highlight trailing whitespace.

Test Plan

Submitted this diff... saw no trailing whitespace.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5253
Build 5271: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29697.Apr 12 2015, 11:37 AM

joshuaspence retitled this revision from to Trim trailing whitespace from diff hints.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 11:37 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

We saw some of these at an onsite meeting recently, I'm definitely onboard with getting rid of them if there are any more.

This revision is now accepted and ready to land.Apr 12 2015, 12:15 PM

Closed by commit rARCbf1b30ae2635: Trim trailing whitespace from diff hints (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

2 lines

Diff 29697

View Options

src/workflow/ArcanistDiffWorkflow.php

Trim trailing whitespace from diff hintsClosedPublicActions