Page MenuHomePhabricator
Differential D12367

Improve `LINT_KEYWORD_CASING` linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 11:24 AM.
Tags
None
Referenced Files
F18992820: D12367.diff
Nov 19 2025, 4:22 AM
F18788400: D12367.diff
Oct 15 2025, 4:44 AM
F18783987: D12367.id29695.diff
Oct 13 2025, 11:25 AM
F18651723: D12367.id29695.diff
Sep 21 2025, 5:10 AM
F18627346: D12367.diff
Sep 16 2025, 3:46 AM
F18420411: D12367.diff
Aug 30 2025, 4:14 PM
F18227296: D12367.id29717.diff
Aug 20 2025, 5:52 AM
F18200062: D12367.id29717.diff
Aug 18 2025, 3:59 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule
Summary

Ref T7409. Improve ArcanistXHPASTLinter::LINT_KEYWORD_CASING to include additional token types. Based on Generic_Sniffs_PHP_LowerCaseKeywordSniff.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29695.Apr 12 2015, 11:24 AM
joshuaspence retitled this revision from to Improve `LINT_KEYWORD_CASING` linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 11:24 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 12 2015, 12:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 12:19 PM
Closed by commit rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
150 lines

Diff 29717

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility