Page MenuHomePhabricator
Differential D12367

Improve `LINT_KEYWORD_CASING` linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 11:24 AM.
Tags
None
Referenced Files
F15470445: D12367.id29695.diff
Fri, Apr 4, 10:17 PM
F15466375: D12367.diff
Thu, Apr 3, 4:50 AM
F15453364: D12367.id.diff
Sat, Mar 29, 11:12 AM
F15453363: D12367.id29695.diff
Sat, Mar 29, 11:12 AM
F15453362: D12367.id29717.diff
Sat, Mar 29, 11:12 AM
F15453305: D12367.diff
Sat, Mar 29, 10:48 AM
F15386459: D12367.id29717.diff
Sat, Mar 15, 12:38 AM
F15384673: D12367.id29695.diff
Fri, Mar 14, 8:32 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule
Summary

Ref T7409. Improve ArcanistXHPASTLinter::LINT_KEYWORD_CASING to include additional token types. Based on Generic_Sniffs_PHP_LowerCaseKeywordSniff.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29695.Apr 12 2015, 11:24 AM
joshuaspence retitled this revision from to Improve `LINT_KEYWORD_CASING` linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 11:24 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 12 2015, 12:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 12:19 PM
Closed by commit rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
150 lines

Diff 29717

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility