Page MenuHomePhabricator
Differential D12366

Add a linter rule for uppercase constant definitions
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 10:05 AM.
Tags
None
Referenced Files
F19489967: D12366.id29694.diff
Thu, Jan 8, 6:12 AM
F19306681: D12366.id29712.diff
Wed, Dec 24, 6:01 PM
F18864950: D12366.id29694.diff
Nov 3 2025, 9:27 AM
F18803878: D12366.id.diff
Oct 18 2025, 4:26 AM
F18799171: D12366.diff
Oct 17 2025, 12:19 PM
F18787792: D12366.id29716.diff
Oct 15 2025, 1:34 AM
F18757236: D12366.diff
Oct 5 2025, 4:19 PM
F18685523: D12366.id29712.diff
Sep 26 2025, 11:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCf86f4f24e617: Add a linter rule for uppercase constant definitions
Summary

Ref T7409. Adds a linter rule to ensure that constant are defined as being uppercase. Based on Generic_Sniffs_NamingConventions_UpperCaseConstantNameSniff.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29694.Apr 12 2015, 10:05 AM
joshuaspence retitled this revision from to Add a linter rule for uppercase constant definitions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 10:05 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Apr 12 2015, 11:48 AM
joshuaspence edited edge metadata.
epriestley accepted this revision.Apr 12 2015, 12:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 12:18 PM
joshuaspence updated this revision to Diff 29712.Apr 12 2015, 9:24 PM
joshuaspence edited edge metadata.

Change to LINT_NAMING_CONVENTIONS

Closed by commit rARCf86f4f24e617: Add a linter rule for uppercase constant definitions (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
80 lines
__tests__/
xhpast/
12 lines
4 lines

Diff 29716

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/constant-case.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

Loading...
Phabricator · Built by Phacility