Page MenuHomePhabricator
Differential D12363

Modernize Phrequent and Commit query ordering/paging
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 3:59 AM.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP9c7c13ffc88a: Modernize Phrequent and Commit query ordering/paging
Summary

Ref T7803. Fixes T3870. Move these away from pagingColumn / reversePaging.

Test Plan
  • Tested/paged audit query.
  • Poked at Phrequent. Didn't seem any more broken than before.

Diff Detail

Repository
rP Phabricator
Branch
rpaging13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5246
Build 5264: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29686.Apr 12 2015, 3:59 AM
epriestley retitled this revision from to Modernize Phrequent and Commit query ordering/paging.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7803: Implement a composite query which unifies cursor paging across subqueries, Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 4:00 AM
btrahan accepted this revision.Apr 13 2015, 5:31 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:31 PM
Closed by commit rP9c7c13ffc88a: Modernize Phrequent and Commit query ordering/paging (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
4 lines
phrequent/
query/
124 lines
infrastructure/
query/
policy/
22 lines

Diff 29686

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/phrequent/query/PhrequentUserTimeQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility