Differential D12359

Modernize Feed and Phlux ordering/paging
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 2:41 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rP8bd1ab9d136f: Modernize Feed and Phlux ordering/paging

Summary

Ref T7803. Move these off getReversePaging() / getPagingColumn().

Test Plan

Paged through Phlux and Feed.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29681.Apr 12 2015, 2:41 AM

epriestley retitled this revision from to Modernize Feed and Phlux ordering/paging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 2:41 AM

btrahan accepted this revision.Apr 13 2015, 5:26 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:26 PM

Closed by commit rP8bd1ab9d136f: Modernize Feed and Phlux ordering/paging (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

query/

PhabricatorFeedQuery.php

24 lines

phlux/

query/

PhluxVariableQuery.php

41 lines

Diff 29758

View Options

src/applications/feed/query/PhabricatorFeedQuery.php