Differential D12357

Modernize ProjectQuery paging/ordering
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 2:10 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rPd496f4d28c7c: Modernize ProjectQuery paging/ordering

Summary

Ref T7803. Move ProjectQuery off getReversePaging() / getPagingColumn() and onto order vectors.

Test Plan

Set project page size to 3 and paged back and forth.

Diff Detail

Repository

rP Phabricator

Branch

rpaging7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5239
Build 5257: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29679.Apr 12 2015, 2:10 AM

epriestley retitled this revision from to Modernize ProjectQuery paging/ordering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 2:10 AM

btrahan accepted this revision.Apr 13 2015, 5:23 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:23 PM

Closed by commit rPd496f4d28c7c: Modernize ProjectQuery paging/ordering (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

26 lines

Diff 29679

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Modernize ProjectQuery paging/orderingClosedPublicActions