Page MenuHomePhabricator

Make formatOrderClause() safer
ClosedPublic

Authored by epriestley on Apr 11 2015, 4:08 PM.
Tags
None
Referenced Files
F16391388: D12351.diff
Mon, Jun 16, 12:36 AM
F16378035: D12351.diff
Sun, Jun 15, 11:21 PM
Unknown Object (File)
May 9 2025, 2:33 PM
Unknown Object (File)
May 8 2025, 8:58 PM
Unknown Object (File)
May 8 2025, 8:58 PM
Unknown Object (File)
May 8 2025, 8:58 PM
Unknown Object (File)
May 7 2025, 10:41 AM
Unknown Object (File)
May 6 2025, 1:01 PM
Subscribers

Details

Summary

Ref T7803. Instead of trusting subqueries to provide safe values, escape them explicitly.

(We'll probably have a few cases somewhere where this doesn't work, but can make them the exception rather than the rule.)

Test Plan

Issued all "order" queries in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
rpaging1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5232
Build 5250: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make formatOrderClause() safer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.