Differential D12345

Conpherence - Fix missing method from D12336; bad branch management. =/
ClosedPublic
Actions

Authored by btrahan on Apr 10 2015, 5:18 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence

Commits

Restricted Diffusion Commit
rP238381a623b6: Conpherence - Fix missing method from D12336; bad branch management. =/

Summary

Ref T7795.

Test Plan

updating a conpherence works once more

Diff Detail

Repository

rP Phabricator

Branch

T7795

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5225
Build 5243: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29660.Apr 10 2015, 5:18 PM

btrahan added a task: T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

btrahan retitled this revision from to Conpherence - Fix missing method from D12336; bad branch management. =/.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 10 2015, 5:18 PM

epriestley accepted this revision.Apr 10 2015, 5:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 10 2015, 5:18 PM

Closed by commit rP238381a623b6: Conpherence - Fix missing method from D12336; bad branch management. =/ (authored by btrahan, committed by btrahan). · Explain WhyApr 10 2015, 5:18 PM

This revision was automatically updated to reflect the committed changes.

This was a terrible D12345.

abika mentioned this in T12255: Landing differential from other author does not preserve ownership.Feb 13 2017, 5:41 PM

chad mentioned this in Z1336: General Chat.Aug 31 2017, 2:27 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadQuery.php

8 lines

Diff 29660

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Conpherence - Fix missing method from D12336; bad branch management. =/ClosedPublicActions