Differential D12328

Make taller tables the default for AphrontTableView
ClosedPublic
Actions

Authored by chad on Apr 8 2015, 3:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 8:11 AM

	Unknown Object (File)
	Fri, May 3, 7:53 AM

	Unknown Object (File)
	Thu, Apr 25, 1:50 AM

	Unknown Object (File)
	Wed, Apr 24, 8:02 AM

	Unknown Object (File)
	Fri, Apr 19, 3:56 AM

	Unknown Object (File)
	Apr 8 2024, 12:52 AM

	Unknown Object (File)
	Apr 4 2024, 2:14 AM

	Unknown Object (File)
	Apr 3 2024, 4:56 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP21f0ce736269: Make taller tables the default for AphrontTableView

Summary

I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh.

Test Plan

Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29615.Apr 8 2015, 3:24 PM

chad retitled this revision from to Make taller tables the default for AphrontTableView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 8 2015, 3:24 PM

epriestley accepted this revision.Apr 8 2015, 3:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2015, 3:29 PM

Closed by commit rP21f0ce736269: Make taller tables the default for AphrontTableView (authored by chad, committed by chad). · Explain WhyApr 8 2015, 3:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

22 lines

src/

applications/

phortune/

view/

PhortuneChargeTableView.php

1 line

PhortuneOrderTableView.php

1 line

PhortuneSubscriptionTableView.php

1 line

view/

control/

AphrontTableView.php

9 lines

webroot/

rsrc/

css/

aphront/

12 lines

js/

application/

diffusion/

behavior-commit-graph.js

2 lines

Diff 29618

resources/celerity/map.php

Loading...

src/applications/phortune/view/PhortuneChargeTableView.php

Loading...

src/applications/phortune/view/PhortuneOrderTableView.php

Loading...

src/applications/phortune/view/PhortuneSubscriptionTableView.php

Loading...

src/view/control/AphrontTableView.php

Loading...

webroot/rsrc/css/aphront/table-view.css

Loading...

webroot/rsrc/js/application/diffusion/behavior-commit-graph.js

Loading...