Page MenuHomePhabricator

Make taller tables the default for AphrontTableView
ClosedPublic

Authored by chad on Apr 8 2015, 3:24 PM.
Tags
None
Referenced Files
F18220425: D12328.id29615.diff
Tue, Aug 19, 2:44 PM
F18166021: D12328.id29618.diff
Fri, Aug 15, 9:14 AM
F17819481: D12328.id.diff
Sat, Jul 26, 1:15 AM
F17802519: D12328.id29618.diff
Fri, Jul 25, 9:11 AM
F17770592: D12328.id.diff
Jul 23 2025, 9:45 AM
F17750652: D12328.diff
Jul 22 2025, 3:58 AM
F17750348: D12328.diff
Jul 22 2025, 3:16 AM
Unknown Object (File)
Jun 26 2025, 1:43 PM
Subscribers

Details

Summary

I considered at the time just making all tables taller. This removes the special casing and adds the space universally. On first glance all smaller tables look great, but Diffusion seems a little bloated. After a short time period though that went away for me. I do think Diffusion overall needs a UI refresh.

Test Plan

Tested numerous tables in Phortune, Diffusion, etc. Spacing feels more readable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Make taller tables the default for AphrontTableView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.