Page MenuHomePhabricator
Differential D12315

Restructure cache checks to improve modularity
ClosedPublic
Actions

Authored by epriestley on Apr 7 2015, 8:41 PM.
Tags
None
Referenced Files
F15517588: D12315.id.diff
Sat, Apr 19, 6:47 AM
F15516753: D12315.diff
Fri, Apr 18, 9:03 PM
F15512844: D12315.diff
Thu, Apr 17, 2:26 PM
F15474155: D12315.id29588.diff
Sun, Apr 6, 5:42 AM
F15457223: D12315.diff
Sun, Mar 30, 3:03 PM
F15398213: D12315.diff
Mar 16 2025, 11:49 PM
F15395251: D12315.id29592.diff
Mar 16 2025, 4:24 AM
Unknown Object (File)
Feb 8 2025, 3:32 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support
Commits
Restricted Diffusion Commit
rP0880788bd4cf: Restructure cache checks to improve modularity
Summary

Ref T5501. This code was headed down a bad road; dump an indirection layer between rendering and data gatehring.

In particular, this will make it much easier to lift these issues into setup warnings eventually.

Test Plan

Viewed cache status page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29588.Apr 7 2015, 8:41 PM
epriestley retitled this revision from to Restructure cache checks to improve modularity.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 7 2015, 8:41 PM
btrahan accepted this revision.Apr 7 2015, 9:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2015, 9:02 PM
Closed by commit rP0880788bd4cf: Restructure cache checks to improve modularity (authored by epriestley, committed by epriestley). · Explain WhyApr 7 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29592

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/cache/spec/PhabricatorCacheSpec.php

Loading...
View Options

src/applications/cache/spec/PhabricatorDataCacheSpec.php

Loading...
View Options

src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
Phabricator · Built by Phacility