Page MenuHomePhabricator
Differential D12260

Don't revert Conpherence page titles when updating notifications
ClosedPublic
Actions

Authored by epriestley on Apr 2 2015, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:18 PM
Unknown Object (File)
Sun, Apr 21, 3:57 PM
Unknown Object (File)
Wed, Apr 17, 2:01 PM
Unknown Object (File)
Sun, Apr 14, 10:57 PM
Unknown Object (File)
Sat, Apr 6, 5:30 PM
Unknown Object (File)
Mar 13 2024, 8:23 PM
Unknown Object (File)
Feb 20 2024, 10:41 PM
Unknown Object (File)
Feb 13 2024, 10:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7709: Browser Page Title in full Conpherence reverts after clicking new thread
Commits
Restricted Diffusion Commit
rP2ecdbbec10bf: Don't revert Conpherence page titles when updating notifications
Summary

Fixes T7709. JX.Title deals with adding (1), etc., counts, so send updates through it.

Test Plan

Clicked between some threads in Conpherence, no title flickering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29445.Apr 2 2015, 1:21 PM
epriestley retitled this revision from to Don't revert Conpherence page titles when updating notifications.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7709: Browser Page Title in full Conpherence reverts after clicking new thread.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 2 2015, 1:21 PM
epriestley mentioned this in T7735: Conpherence threadData.title omits glyphs/names.Apr 2 2015, 1:24 PM
btrahan accepted this revision.Apr 2 2015, 8:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 8:02 PM
Closed by commit rP2ecdbbec10bf: Don't revert Conpherence page titles when updating notifications (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2015, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
41 lines
webroot/
rsrc/
js/
application/
conpherence/
5 lines
core/
6 lines

Diff 29456

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
View Options

webroot/rsrc/js/core/Title.js

Loading...
Phabricator · Built by Phacility