Page MenuHomePhabricator

Hide Search text better
ClosedPublic

Authored by chad on Mar 31 2015, 4:50 PM.
Tags
None
Referenced Files
F14774420: D12219.id29362.diff
Fri, Jan 24, 1:57 AM
F14774419: D12219.id29361.diff
Fri, Jan 24, 1:57 AM
F14774418: D12219.id29360.diff
Fri, Jan 24, 1:57 AM
F14774417: D12219.id.diff
Fri, Jan 24, 1:57 AM
F14774416: D12219.diff
Fri, Jan 24, 1:57 AM
Unknown Object (File)
Tue, Jan 14, 5:54 PM
Unknown Object (File)
Sun, Jan 12, 3:54 PM
Unknown Object (File)
Dec 20 2024, 9:33 AM
Subscribers
Tokens
"Orange Medal" token, awarded by btrahan.

Details

Summary

Previously, this text was transparent, moved it to a new span and set visibility on it.

Test Plan

review search in FF, Chrome. Text no longer displays.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Hide Search text better.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.

I think this is only for screen readers, so maybe using the aural stuff is a cleaner fix?

https://secure.phabricator.com/book/phabcontrib/article/assistive_technologies/

This revision is now accepted and ready to land.Mar 31 2015, 4:53 PM
chad edited edge metadata.
  • aural
This revision was automatically updated to reflect the committed changes.