diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -69,6 +69,7 @@ 'ArcanistDifferentialRevisionHash' => 'differential/constants/ArcanistDifferentialRevisionHash.php', 'ArcanistDifferentialRevisionStatus' => 'differential/constants/ArcanistDifferentialRevisionStatus.php', 'ArcanistDownloadWorkflow' => 'workflow/ArcanistDownloadWorkflow.php', + 'ArcanistESLintLinter' => 'lint/linter/ArcanistESLintLinter.php', 'ArcanistEventType' => 'events/constant/ArcanistEventType.php', 'ArcanistExportWorkflow' => 'workflow/ArcanistExportWorkflow.php', 'ArcanistExternalLinter' => 'lint/linter/ArcanistExternalLinter.php', @@ -268,6 +269,7 @@ 'ArcanistDifferentialCommitMessageParserException' => 'Exception', 'ArcanistDifferentialDependencyGraph' => 'AbstractDirectedGraph', 'ArcanistDownloadWorkflow' => 'ArcanistWorkflow', + 'ArcanistESLintLinter' => 'ArcanistExternalLinter', 'ArcanistEventType' => 'PhutilEventType', 'ArcanistExportWorkflow' => 'ArcanistWorkflow', 'ArcanistExternalLinter' => 'ArcanistFutureLinter', diff --git a/src/lint/linter/ArcanistESLintLinter.php b/src/lint/linter/ArcanistESLintLinter.php new file mode 100644 --- /dev/null +++ b/src/lint/linter/ArcanistESLintLinter.php @@ -0,0 +1,66 @@ +setPath($path); + $message->setLine($parts[0]); + $message->setCode($this->getLinterName()); + $message->setDescription(implode(' ', $parts)); + $message->setSeverity($severity); + + $messages[] = $message; + } + } + + return $messages; + } + +} diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php --- a/src/lint/linter/ArcanistExternalLinter.php +++ b/src/lint/linter/ArcanistExternalLinter.php @@ -52,7 +52,7 @@ * this method and return true so execution continues when it exits with * a nonzero status. * - * @param bool Return true to continue on nonzero error code. + * @return bool Return true to continue on nonzero error code. * @task bin */ public function shouldExpectCommandErrors() {