Differential D12156

Fixed XUnitTestEngine to use quotes for xunit console call.
Needs ReviewPublic
Actions

Authored by igorgatis on Mar 25 2015, 12:04 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7553: XUnitTestEngine does not handle properly whitespaces in runner's path

Summary

XUnitTestEngine does not wrap test engine path causing trouble when the path contains whitespaces.
This fixes T7553: XUnitTestEngine does not handle properly whitespaces in runner's path.

Test Plan

Manual verification.

Diff Detail

Repository

rARC Arcanist

Branch

T7553

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 4973
Build 4991: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	72 ms	PhpunitTestEngineTestCase::testSearchLocations
	9 ms	PhutilUnitTestEngineTestCase::testFailSkip
	0 ms	PhutilUnitTestEngineTestCase::testPass
	0 ms	PhutilUnitTestEngineTestCase::testTryTestCases
	0 ms	PhutilUnitTestEngineTestCase::testTryTestMap

Event Timeline

igorgatis updated this revision to Diff 29218.Mar 25 2015, 12:04 PM

igorgatis added a task: T7553: XUnitTestEngine does not handle properly whitespaces in runner's path.

igorgatis retitled this revision from to Fixed XUnitTestEngine to use quotes for xunit console call..

igorgatis updated this object.

igorgatis edited the test plan for this revision. (Show Details)

igorgatis added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 25 2015, 12:04 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

What if the path contains quotes?

epriestley mentioned this in T10038: Plan the mid-term pathway for unit-test/linter bindings.Dec 22 2015, 12:59 PM

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

XUnitTestEngine.php

2 lines

Diff 29218

View Options

src/unit/engine/XUnitTestEngine.php

Fixed XUnitTestEngine to use quotes for xunit console call.Needs ReviewPublicActions