Page MenuHomePhabricator

Conpherence - more threadManager stuff and get scrolling working
ClosedPublic

Authored by btrahan on Mar 10 2015, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 2:41 PM
Unknown Object (File)
Fri, May 3, 2:40 AM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Mon, Apr 29, 2:18 PM
Unknown Object (File)
Mon, Apr 22, 10:46 PM
Unknown Object (File)
Fri, Apr 12, 9:19 PM
Subscribers

Details

Summary

Ref T7014. The main conpherence view is kind of broken without this in subtle ways because of /conpherence/ versus /conpherence/x/ init'ing things differently; this fixes that. Moves more normal view conpherence logic into threadManager. Makes all the display code happen outside of threadManager, setting us up for some display manager later maybe.

Test Plan

sent messages, updated title, etc and the messages pane auto scrolled correctly!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - more threadManager stuff and get scrolling working.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2015, 8:53 PM
This revision was automatically updated to reflect the committed changes.