Differential D11990

Check for untracked files in order to fire untracked file prompt
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 10:44 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7465: arc diff does not prompt to add untracked files using git

Commits

rARCc36b4ceb1849: Check for untracked files in order to fire untracked file prompt

Summary

Fixes T7465. I think I just missed this when untangling the old logic.

Test Plan

Ran arc diff with only untrakced files, saw warning.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28871.Mar 5 2015, 10:44 PM

epriestley retitled this revision from to Check for untracked files in order to fire untracked file prompt.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7465: arc diff does not prompt to add untracked files using git.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 10:44 PM

chad accepted this revision.Mar 5 2015, 10:44 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Mar 5 2015, 10:44 PM

Closed by commit rARCc36b4ceb1849: Check for untracked files in order to fire untracked file prompt (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:45 PM

This revision was automatically updated to reflect the committed changes.

nevogd mentioned this in D11995: Add untracked files to commit using prompt.Mar 6 2015, 8:17 AM

nevogd mentioned this in T7465: arc diff does not prompt to add untracked files using git.Mar 6 2015, 8:20 AM

epriestley mentioned this in rARC3d871b42146e: Add untracked files to commit using prompt.Mar 6 2015, 12:41 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistWorkflow.php

2 lines

Diff 28872

View Options

src/workflow/ArcanistWorkflow.php

Check for untracked files in order to fire untracked file promptClosedPublicActions